Skip to content

Adopt lazy imports from Terra#338

Merged
manoelmarques merged 1 commit into
qiskit-community:mainfrom
manoelmarques:lazy
Mar 4, 2022
Merged

Adopt lazy imports from Terra#338
manoelmarques merged 1 commit into
qiskit-community:mainfrom
manoelmarques:lazy

Conversation

@manoelmarques
Copy link
Copy Markdown
Contributor

@manoelmarques manoelmarques commented Mar 3, 2022

Summary

Adopt the API implemented in Qiskit/qiskit#7525

Details and comments

@manoelmarques manoelmarques added type: enhancement ✨ Features or aspects to improve run_slow 🐢 PR will run all unit tests decorated as slow labels Mar 3, 2022
@manoelmarques manoelmarques self-assigned this Mar 3, 2022
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 3, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1930324644

  • 49 of 75 (65.33%) changed or added relevant lines in 16 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.8%) to 84.727%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_machine_learning/runtime/torch_runtime_client.py 3 4 75.0%
qiskit_machine_learning/datasets/breast_cancer.py 1 3 33.33%
qiskit_machine_learning/datasets/digits.py 1 3 33.33%
qiskit_machine_learning/datasets/iris.py 1 3 33.33%
qiskit_machine_learning/datasets/wine.py 1 3 33.33%
qiskit_machine_learning/neural_networks/circuit_qnn.py 6 8 75.0%
qiskit_machine_learning/connectors/torch_connector.py 3 6 50.0%
qiskit_machine_learning/algorithms/distribution_learners/qgan/pytorch_discriminator.py 9 13 69.23%
qiskit_machine_learning/datasets/ad_hoc.py 1 5 20.0%
qiskit_machine_learning/datasets/gaussian.py 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
qiskit_machine_learning/algorithms/distribution_learners/qgan/pytorch_discriminator.py 2 79.12%
Totals Coverage Status
Change from base Build 1924613903: 0.8%
Covered Lines: 2857
Relevant Lines: 3372
💛 - Coveralls

@manoelmarques manoelmarques merged commit 6e0f65f into qiskit-community:main Mar 4, 2022
@manoelmarques manoelmarques deleted the lazy branch March 4, 2022 00:17
oscar-wallis pushed a commit that referenced this pull request Feb 16, 2024
@manoelmarques
Adopt lazy imports from Terra (#338)
bef412d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adekusar-drl adekusar-drl adekusar-drl approved these changes

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner

@pbark pbark Awaiting requested review from pbark

@woodsp-ibm woodsp-ibm Awaiting requested review from woodsp-ibm

Assignees

@manoelmarques manoelmarques

Labels

run_slow 🐢 PR will run all unit tests decorated as slow type: enhancement ✨ Features or aspects to improve

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@manoelmarques @coveralls @adekusar-drl